[repo] Bump Microsoft.Extensions.Options to 6.0.0+ #4054
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanwest
reviewed
Jan 3, 2023
| <MicrosoftExtensionsLoggingConfigurationPkgVer>[3.1.0,)</MicrosoftExtensionsLoggingConfigurationPkgVer> | ||
| <MicrosoftExtensionsOptionsPkgVer>[5.0.0,)</MicrosoftExtensionsOptionsPkgVer> | ||
| <MicrosoftExtensionsLoggingConfigurationPkgVer>$(MicrosoftExtensionsLoggingPkgVer)</MicrosoftExtensionsLoggingConfigurationPkgVer> | ||
| <MicrosoftExtensionsOptionsPkgVer>[6.0.0,)</MicrosoftExtensionsOptionsPkgVer> |
There was a problem hiding this comment.
I recall there was a reason we needed 5+, but can you remind me why we couldn't have used 3.1.0?
There was a problem hiding this comment.
We use this CreateInstance method (which was added in 5.0) to fire delegates when options are retrieved which is used for the retrieve-environment-variables-from-iconfiguration feature.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4054 +/- ##
==========================================
+ Coverage 85.41% 85.45% +0.04%
==========================================
Files 289 289
Lines 11229 11229
==========================================
+ Hits 9591 9596 +5
+ Misses 1638 1633 -5
|
alanwest
reviewed
Jan 5, 2023
There was a problem hiding this comment.
@CodeBlanch based on our SIG conversation, did we decide to punt on making this change, or do you think we should still proceed?
|
@alanwest Discussed this with @tarekgh. The guidance we received is:
I'm going to close this based on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #4046
OpenTelemetry SDK has a dependency on
Microsoft.Extensions.Optionspackage. The current version specified inCommon.propsis 5.0.0 and above. The version 5.0.0 ofMicrosoft.Extensions.Optionspackage is deprecated and no longer maintained: https://www.nuget.org/packages/Microsoft.Extensions.Options/5.0.0Changes
Microsoft.Extensions.Optionsto [6.0.0,)Microsoft.Extensions.DependencyInjectionreference at [6.0.0,) to SDK to resolve conflicts