Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back aspnetcore instrumentation in example #3021

Merged
merged 2 commits into from
Mar 11, 2022

Conversation

cijothomas
Copy link
Member

Add back instrumentation which got accidentally removed in #2989

@cijothomas cijothomas requested a review from a team March 11, 2022 05:39
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #3021 (1772fcd) into main (d55de34) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 1772fcd differs from pull request most recent head c0c59eb. Consider uploading reports for the commit c0c59eb to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3021      +/-   ##
==========================================
+ Coverage   84.15%   84.17%   +0.02%     
==========================================
  Files         258      258              
  Lines        9093     9093              
==========================================
+ Hits         7652     7654       +2     
+ Misses       1441     1439       -2     
Impacted Files Coverage Δ
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 96.87% <0.00%> (-0.79%) ⬇️
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 73.68% <0.00%> (+0.87%) ⬆️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 82.35% <0.00%> (+5.88%) ⬆️

@cijothomas
Copy link
Member Author

Merging, intentionally ignoring the APIcompact failure (its flaky) as this PR is only touching examples, so no risk.

@cijothomas cijothomas merged commit 5f509bf into open-telemetry:main Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants