Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TracerProviderSdkTest for legacy activities #2665

Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions test/OpenTelemetry.Tests/Trace/TracerProviderSdkTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -647,6 +647,7 @@ public void SdkSamplesLegacyActivityWithAlwaysOnSampler()

Assert.True(activity.IsAllDataRequested);
Assert.True(activity.ActivityTraceFlags.HasFlag(ActivityTraceFlags.Recorded));
Assert.EndsWith("01", activity.Id);

activity.Stop();
}
Expand All @@ -665,6 +666,7 @@ public void SdkSamplesLegacyActivityWithAlwaysOffSampler()

Assert.False(activity.IsAllDataRequested);
Assert.False(activity.ActivityTraceFlags.HasFlag(ActivityTraceFlags.Recorded));
Assert.EndsWith("00", activity.Id);

activity.Stop();
}
Expand All @@ -688,6 +690,7 @@ public void SdkSamplesLegacyActivityWithCustomSampler(SamplingDecision samplingD

Assert.Equal(isAllDataRequested, activity.IsAllDataRequested);
Assert.Equal(hasRecordedFlag, activity.ActivityTraceFlags.HasFlag(ActivityTraceFlags.Recorded));
Assert.EndsWith(hasRecordedFlag ? "01" : "00", activity.Id);

activity.Stop();
}
Expand Down Expand Up @@ -762,6 +765,7 @@ public void SdkSamplesLegacyActivityWithRemoteParentWithCustomSampler(SamplingDe
activity.Start();
Assert.Equal(expectedIsAllDataRequested, activity.IsAllDataRequested);
Assert.Equal(hasRecordedFlag, activity.ActivityTraceFlags.HasFlag(ActivityTraceFlags.Recorded));
Assert.EndsWith(hasRecordedFlag ? "01" : "00", activity.Id);
activity.Stop();
}

Expand Down Expand Up @@ -792,6 +796,7 @@ public void SdkSamplesLegacyActivityWithRemoteParentWithAlwaysOnSampler(Activity
activity.Start();
Assert.True(activity.IsAllDataRequested);
Assert.True(activity.ActivityTraceFlags.HasFlag(ActivityTraceFlags.Recorded));
Assert.EndsWith("01", activity.Id);
activity.Stop();
}

Expand Down Expand Up @@ -822,6 +827,7 @@ public void SdkSamplesLegacyActivityWithRemoteParentWithAlwaysOffSampler(Activit
activity.Start();
Assert.False(activity.IsAllDataRequested);
Assert.False(activity.ActivityTraceFlags.HasFlag(ActivityTraceFlags.Recorded));
Assert.EndsWith("00", activity.Id);
activity.Stop();
}

Expand Down