Stress test modified to have a reader to force sdk to do aggregation #2646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utpilla
approved these changes
Nov 20, 2021
Codecov Report
@@ Coverage Diff @@
## main #2646 +/- ##
==========================================
- Coverage 81.31% 81.28% -0.04%
==========================================
Files 245 245
Lines 8645 8645
==========================================
- Hits 7030 7027 -3
- Misses 1615 1618 +3
|
reyang
reviewed
Nov 20, 2021
| using var meterProvider = Sdk.CreateMeterProviderBuilder() | ||
| .AddMeter(TestMeter.Name) | ||
| .AddReader(reader) |
There was a problem hiding this comment.
Suggested change
| .AddReader(reader) | |
| .AddInMemoryReader(new List<Metric>()) |
|
Closing in favor of #2640 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without adding a reader, we'll assume @utpilla did unbelievable magic in #2596 and improved throughput from 7 M/sec to 70 M/sec. 😆