Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JaegerExporter batching changes #1732

Merged
merged 7 commits into from
Jan 30, 2021

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Jan 27, 2021

Fixes #1388
Fixes #1730

See:

Changes

Removes the logic we had to generate a process/batch for each service when sending spans to Jaeger.

Impact

Using the new code Jaeger UI v1.12.0 spans will look like this:

image

Before they looked like this:

image

What the extra logic was doing was tricking Jaeger UI into treating the non-reporting dependencies as dependencies WRT the UI.

  • CHANGELOG.md updated for non-trivial changes

@CodeBlanch CodeBlanch requested a review from a team January 27, 2021 22:47
@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #1732 (520ae75) into main (d724634) will increase coverage by 0.04%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1732      +/-   ##
==========================================
+ Coverage   83.11%   83.16%   +0.04%     
==========================================
  Files         193      193              
  Lines        6005     5986      -19     
==========================================
- Hits         4991     4978      -13     
+ Misses       1014     1008       -6     
Impacted Files Coverage Δ
...nTelemetry.Exporter.Jaeger/Implementation/Batch.cs 84.09% <ø> (+3.65%) ⬆️
...rc/OpenTelemetry.Exporter.Jaeger/JaegerExporter.cs 83.33% <72.72%> (-1.93%) ⬇️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 82.35% <0.00%> (+5.88%) ⬆️
...ZPages/Implementation/ZPagesExporterEventSource.cs 62.50% <0.00%> (+6.25%) ⬆️

@CodeBlanch
Copy link
Member Author

Sorry @ndrwrbgs I know this feature was important to you. Our job in OpenTelemetry .NET is to be compliant with the main OpenTelemetry spec so we have to do this. @cijothomas is going to take up pursuing a change through the official spec channels.

@cijothomas cijothomas merged commit 959f443 into open-telemetry:main Jan 30, 2021
@CodeBlanch CodeBlanch deleted the jaeger-batch branch February 12, 2021 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JaegerExporter Resource mapping is not spec compliant. Incorrect conversion to Jaeger model
2 participants