Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1388
Fixes #1730
See:
Changes
Removes the logic we had to generate a process/batch for each service when sending spans to Jaeger.
Impact
Using the new code Jaeger UI v1.12.0 spans will look like this:
Before they looked like this:
What the extra logic was doing was tricking Jaeger UI into treating the non-reporting dependencies as dependencies WRT the UI.
CHANGELOG.md
updated for non-trivial changes