Enable .net5.0

[eddynaka]

Fixes #.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

• CHANGELOG.md updated for non-trivial changes
• Design discussion issue #
• Changes in public API reviewed

[eddynaka]

@alanwest @cijothomas , we might have some issues here....
So, that looks like its happening in gRPC only. The quantity of activities changed (check the test GrpcAndHttpClientInstrumentationIsInvoked).

don't know yet what else is happening...

[eddynaka]

And the second thing that I saw failing is this: GrpcPropagatesContextWithSuppressInstrumentation. And this was not for this branch...any one knows what might be the issue?

[alanwest]

So, that looks like its happening in gRPC only. The quantity of activities changed (check the test GrpcAndHttpClientInstrumentationIsInvoked).

I tracked this down to the fact that HttpClient instrumentation does not get invoked when using Grpc.Net.Client on .NET 5. See #1490 for more details.

Few options for moving forward with this PR in the meantime:

1. We could hold off on porting the gRPC test suite to .NET 5.
2. This test could temporarily be fixed to work on .NET 5 by configuring the GrpcChannel as follows:

using var channel = GrpcChannel.ForAddress(uri, new GrpcChannelOptions()
{
    HttpClient = new HttpClient(),
});

[alanwest]

And the second thing that I saw failing is this: GrpcPropagatesContextWithSuppressInstrumentation. And this was not for this branch...any one knows what might be the issue?

Ugh, I noted this issue as well on your branch when running all the gRPC tests concurrently. Seems concurrency issues keep cropping up with this test suite. I have not yet tracked down the cause, but I will keep poking at it...

[eddynaka]

So, that looks like its happening in gRPC only. The quantity of activities changed (check the test GrpcAndHttpClientInstrumentationIsInvoked).

I tracked this down to the fact that HttpClient instrumentation does not get invoked when using Grpc.Net.Client on .NET 5. See #1490 for more details.

Few options for moving forward with this PR in the meantime:

1. We could hold off on porting the gRPC test suite to .NET 5.
2. This test could temporarily be fixed to work on .NET 5 by configuring the GrpcChannel as follows:

using var channel = GrpcChannel.ForAddress(uri, new GrpcChannelOptions()
{
    HttpClient = new HttpClient(),
});

Should we add this workaround for now? What do you think?

[alanwest]

Should we add this workaround for now? What do you think?

I'm ok with this workaround for now. Maybe inside of a #if NET5_0 block with a comment linking to #1490 just so it's clear why.

[eddynaka]

Should we add this workaround for now? What do you think?

I'm ok with this workaround for now. Maybe inside of a #if NET5_0 block with a comment linking to #1490 just so it's clear why.

just added a if for netcoreapp3.1, since net5_0 wasn't working for me.

[codecov]

Codecov Report

Merging #1486 (7c24a5c) into master (bebc80f) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1486      +/-   ##
==========================================
+ Coverage   81.13%   81.15%   +0.01%     
==========================================
  Files         232      232              
  Lines        6309     6309              
==========================================
+ Hits         5119     5120       +1     
+ Misses       1190     1189       -1     

Impacted Files	Coverage Δ
...tation.AspNetCore/Implementation/HttpInListener.cs	84.80% <0.00%> (-0.80%)	⬇️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs	100.00% <0.00%> (+2.85%)	⬆️
...us/Implementation/PrometheusExporterEventSource.cs	72.72% <0.00%> (+9.09%)	⬆️