Adding MeterProviderBuilder #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1149 +/- ##
==========================================
+ Coverage 77.39% 77.42% +0.02%
==========================================
Files 219 219
Lines 6261 6255 -6
==========================================
- Hits 4846 4843 -3
+ Misses 1415 1412 -3
|
updating changelog
cijothomas
approved these changes
Aug 27, 2020
reyang
reviewed
Aug 28, 2020
| mb.SetMetricPushInterval(TimeSpan.FromSeconds(pushIntervalInSecs)); | ||
| })); | ||
| MeterProvider.SetDefault(Sdk.CreateMeterProviderBuilder() | ||
| .SetProcessor(processor) |
There was a problem hiding this comment.
@cijothomas do we want this to be Set or Add?
There was a problem hiding this comment.
If we allow multiple Processor, then Add. Else Set.
This decision is not clear, so I'll leave it as is until we actually implement Metric Sdk.
(This PR just make consistent pattern as Tracer only - Sdk.CreateMeterBuilder().accumulate_stuff_for_building().Build pattern)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1146.
Changes
Please provide a brief description of the changes here. Update the
CHANGELOG.mdfor non-trivial changes.For significant contributions please make sure you have completed the following items: