Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Milliseconds instead of Millis #1139

Merged
merged 1 commit into from
Aug 22, 2020
Merged

Use Milliseconds instead of Millis #1139

merged 1 commit into from
Aug 22, 2020

Conversation

reyang
Copy link
Member

@reyang reyang commented Aug 22, 2020

Follow up #1135 (comment).

Changes

Replaced all the remaining "Millis" with "Milliseconds".

@reyang reyang requested a review from a team August 22, 2020 03:01
@reyang reyang closed this Aug 22, 2020
@reyang reyang reopened this Aug 22, 2020
@codecov
Copy link

codecov bot commented Aug 22, 2020

Codecov Report

Merging #1139 into master will decrease coverage by 0.04%.
The diff coverage is 58.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1139      +/-   ##
==========================================
- Coverage   77.28%   77.23%   -0.05%     
==========================================
  Files         220      220              
  Lines        6269     6269              
==========================================
- Hits         4845     4842       -3     
- Misses       1424     1427       +3     
Impacted Files Coverage Δ
...penTelemetry/Trace/BatchExportActivityProcessor.cs 37.20% <58.33%> (ø)
...mentation.Http/HttpClientInstrumentationOptions.cs 95.83% <0.00%> (-4.17%) ⬇️
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 77.77% <0.00%> (-3.18%) ⬇️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 61.76% <0.00%> (-2.95%) ⬇️
...us/Implementation/PrometheusExporterEventSource.cs 72.72% <0.00%> (+9.09%) ⬆️

@cijothomas cijothomas merged commit 6676fc4 into master Aug 22, 2020
@cijothomas cijothomas deleted the reyang/ms branch August 22, 2020 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants