Code review.

open-telemetry · Sep 27, 2021 · 5f50191 · 5f50191
1 parent a0020fd
commit 5f50191
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/OpenTelemetry.Extensions.Hosting/Implementation/MeterProviderBuilderHosting.cs b/src/OpenTelemetry.Extensions.Hosting/Implementation/MeterProviderBuilderHosting.cs
@@ -47,6 +47,11 @@ public MeterProviderBuilder Configure(Action<IServiceProvider, MeterProviderBuil
 
         public MeterProvider Build(IServiceProvider serviceProvider)
         {
+            if (serviceProvider == null)
+            {
+                throw new ArgumentNullException(nameof(serviceProvider));
+            }
+
             // Note: Not using a foreach loop because additional actions can be
             // added during each call.
             for (int i = 0; i < this.configurationActions.Count; i++)

diff --git a/src/OpenTelemetry.Extensions.Hosting/Implementation/TracerProviderBuilderHosting.cs b/src/OpenTelemetry.Extensions.Hosting/Implementation/TracerProviderBuilderHosting.cs
@@ -47,6 +47,11 @@ public TracerProviderBuilder Configure(Action<IServiceProvider, TracerProviderBu
 
         public TracerProvider Build(IServiceProvider serviceProvider)
         {
+            if (serviceProvider == null)
+            {
+                throw new ArgumentNullException(nameof(serviceProvider));
+            }
+
             // Note: Not using a foreach loop because additional actions can be
             // added during each call.
             for (int i = 0; i < this.configurationActions.Count; i++)