Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump OTel to 1.7.0 #3213

Merged
merged 23 commits into from
Jan 10, 2024
Merged

Bump OTel to 1.7.0 #3213

merged 23 commits into from
Jan 10, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Jan 4, 2024 •
edited
Loading

Why

Fixes #3204

What

Bump OTel packages to 1.7.0. It includes bumping of indirect dependencies. For details, please check CHANGELOG.
Documentation updated.
Tests adjustment.

Tests

CI

Checklist

  • CHANGELOG.md is updated.
  • Documentation is updated.
  • New features are covered by tests.

Kielek
Kielek commented Jan 4, 2024
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@Kielek Kielek marked this pull request as ready for review January 5, 2024 12:56
@Kielek Kielek requested a review from a team January 5, 2024 12:56
lachmatt
lachmatt reviewed Jan 5, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
pjanotti
pjanotti reviewed Jan 5, 2024
View reviewed changes
Copy link
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A general concern are the explicit reference to some of the Microsoft.Extensions.* packages that were moved to version 8.0 - it seems that if we needed to those for tests many users will have to do the same. That said it is a known issue if there are conflicting versions brought by the application.

Could you just verify that these are really being brought by the test applications? Just to ensure that we are not missing anything on AdditionalDeps and SharedStore.

@Kielek
Copy link
Contributor Author

Kielek commented Jan 9, 2024

A general concern are the explicit reference to some of the Microsoft.Extensions.* packages that were moved to version 8.0 - it seems that if we needed to those for tests many users will have to do the same. That said it is a known issue if there are conflicting versions brought by the application.

Could you just verify that these are really being brought by the test applications? Just to ensure that we are not missing anything on AdditionalDeps and SharedStore.

Double checked, all libraries are transitive dependencies referenced by instrumented libraries.

@Kielek Kielek mentioned this pull request Jan 10, 2024
Closed
@Kielek Kielek enabled auto-merge (squash) January 10, 2024 17:30
@Kielek Kielek merged commit 9a96610 into open-telemetry:main Jan 10, 2024
32 checks passed
@Kielek Kielek deleted the bump-otel-1.7.0 branch January 11, 2024 11:41
@Kielek Kielek mentioned this pull request Jun 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pellared pellared pellared left review comments

@pjanotti pjanotti pjanotti approved these changes

@lachmatt lachmatt lachmatt left review comments

@rajkumar-rangaraj rajkumar-rangaraj rajkumar-rangaraj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump OTel to 1.7.0.
5 participants
@Kielek @pellared @pjanotti @rajkumar-rangaraj @lachmatt