Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] fix local development instructions and dependencies #434

Merged
merged 2 commits into from
Oct 13, 2022
Merged

[frontend] fix local development instructions and dependencies #434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32eb6c9
Fix instructions and dependencies
julianocosta89 Oct 12, 2022
7b40322
Merge branch 'main' into fix/frontend-local-development
austinlparker Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,7 @@ services:
- currencyservice
- otelcol
- productcatalogservice
- quoteservice
- recommendationservice
- shippingservice
logging: *logging
Expand Down
2 changes: 1 addition & 1 deletion src/frontend/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,4 @@ USER nextjs
ENV PORT 8080
EXPOSE ${PORT}

ENTRYPOINT ["npm", "start"]
ENTRYPOINT npm start
3 changes: 1 addition & 2 deletions src/frontend/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@ frontend client by going to <http://localhost:8080/>.
Currently, the easiest way to run the frontend for local development is to execute

```shell
docker compose run --service-ports -e NODE_ENV=development
--volume $(pwd)/src/frontend:/app --volume $(pwd)/pb:/app/pb frontend sh
docker compose run --service-ports -e NODE_ENV=development --volume $(pwd)/src/frontend:/app --volume $(pwd)/pb:/app/pb --user node --entrypoint sh frontend
```

from the root folder.
Expand Down