Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use ENTRYPOINT instead of CMD in Dockerfile #342

Merged
merged 2 commits into from
Aug 24, 2022
Merged

use ENTRYPOINT instead of CMD in Dockerfile #342

merged 2 commits into from
Aug 24, 2022

Conversation

puckpuck
Copy link
Contributor

Changes

  • Use ENTRYPOINT consistently in Dockerfile for all services

@puckpuck puckpuck requested a review from a team August 24, 2022 04:24
julianocosta89
julianocosta89 approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@puckpuck puckpuck merged commit fc997b6 into open-telemetry:main Aug 24, 2022
@puckpuck puckpuck deleted the use-entrypoint branch August 24, 2022 13:48
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
@puckpuck
use ENTRYPOINT (open-telemetry#342)
f34c3db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@julianocosta89 julianocosta89 julianocosta89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@puckpuck @julianocosta89 @reyang