Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new approver fatsheep9146 #216

Closed
wants to merge 1 commit into from

Conversation

fatsheep9146
Copy link
Contributor

Signed-off-by: Ziqi Zhao [email protected]

Adding Ziqi Zhao (fatsheep9146) as demo webstore approvers.

@fatsheep9146 fatsheep9146 requested a review from a team July 19, 2022 11:21
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a violation of https://github.com/open-telemetry/community/blob/main/community-membership.md#requirements-2. Approvers should be nominated by maintainers.

The PR description also lacks the reason / justification, here goes a good example open-telemetry/opentelemetry-dotnet#2065.

@fatsheep9146
Copy link
Contributor Author

This is a violation of https://github.com/open-telemetry/community/blob/main/community-membership.md#requirements-2. Approvers should be nominated by maintainers.

The PR description also lacks the reason / justification, here goes a good example open-telemetry/opentelemetry-dotnet#2065.

That make senses. @cartersocha Would you mind nominating me by a new issue?

@cartersocha
Copy link
Contributor

Yeah I'll submit a PR today or tomorrow. A bit busy today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants