Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grafana] add description panel to dashboards #1989

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

puckpuck
Copy link
Contributor

@puckpuck puckpuck commented Feb 1, 2025

Changes

Fixes #1771

This adds a description panel to the top of each dashboard. The panel includes a short description of the dashboard and a note that it may take 5 minutes for the panels to start rendering data after the demo starts.

2 dashboard panels were also fixed:

  1. Quote Service batch span processor on the Demo dashboard was referencing an incorrect tag value
  2. Top 7 Highest Endpoint Latencies Mean Over Range on the spanmetrics dashboard was referencing an incorrect metric name

Merge Requirements

For new features contributions, please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@puckpuck puckpuck requested a review from a team as a code owner February 1, 2025 21:13
@github-actions github-actions bot added the helm-update-required Requires an update to the Helm chart when released label Feb 1, 2025
Copy link
Member

@mviitane mviitane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice UX improvement! Added few minor comments. The dashboards were working fine.

@mviitane mviitane merged commit 5eb5426 into open-telemetry:main Feb 7, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm-update-required Requires an update to the Helm chart when released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[grafana] Broken dashboards
3 participants