Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OTLP Access logs for the frontend proxy #1751

Closed

Conversation

martinjt
Copy link
Member

Changes

This adds an access_log filter that sends Access Logs from the Frontend Proxy as logs to the collector.

I've tried to keep as close to the semantic conventions as I could for them. I've used Span/Trace semantics for things that made sense.

Merge Requirements

For new features contributions, please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@martinjt martinjt requested a review from a team as a code owner October 25, 2024 16:52
Copy link

github-actions bot commented Nov 2, 2024

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 2, 2024
@puckpuck puckpuck removed the Stale label Nov 4, 2024
@julianocosta89
Copy link
Member

@martinjt could you check the failing checks and update the branch?

@julianocosta89
Copy link
Member

@martinjt when testing it out, I've noticed that the logs have TraceID, but no SpanID.
Is that expected?

@puckpuck
Copy link
Contributor

puckpuck commented Nov 7, 2024

Closing this in favor of #1768

@puckpuck puckpuck closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants