Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Add tracer scope configurator #3137
[SDK] Add tracer scope configurator #3137
Changes from all commits
ae5cdf4
9117eff
127311b
20cb4e9
df36a54
a80800e
694f9c0
f815c3e
9b89786
541c0eb
a67ea85
bcd6e94
2e2afd4
4de93cb
cfd9730
47acb3f
f7dde19
d87997d
2f1ee38
31c73a3
5f6a95f
501fa47
c2bf6f9
47dd040
98ca2c3
be16f38
cd9d360
f0e9df6
7c90e1b
4d16975
5efb9dd
8511e80
bcbcbe2
6bc257e
98ec24d
62c19d6
349c903
ad9e1e1
784b0d4
9452789
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not use default values
= false
.The choice of the default value should not be nested deep in the code, but bubble up in the call stack, up to where the decision is made to use a default.
This will be in the tracer provider factory, when no scope configurator is provided.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a private constructor, so it cannot be called externally and the value of the default is dictated by the spec.