-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Base HTTP Server header files #217
Conversation
Codecov Report
@@ Coverage Diff @@
## master #217 +/- ##
=======================================
Coverage 92.19% 92.19%
=======================================
Files 117 117
Lines 4038 4038
=======================================
Hits 3723 3723
Misses 315 315 |
I think we should add it to Re. safety features - I can add a few lockguard checks in parts of code that accept a new HTTP request, and/or for the case when the same box is being accessed by multiple concurrent clients. There is usually a practical limit to the number of concurrent HTTP requests from one client machine, so the likelihood of a race condition is rather small. I can patch this, you do not have to worry about it. I will approve, use your best judgement to decide on location. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
@maxgolov I agree 100%, I think after all the zPages stuff is approved and merged we will make a future PR to move the zPages and HTTP server to different folders, i.e. Also, I added a file server that comes from your example; let me know if it looks okay. It can be used as a base for other HTTP servers, or serve as an example on how to derive an HTTP server using the base http_server. I also ran the formatter and changed some small cosmetic things (file names) to be consistent with the rest of the repo and to try to pass the CI checks (for some reason they fail, and I think others are having similar issues) |
The CI is failing and it seems to be a transient error. |
This is a PR for the HTTP server base class, which is a lightweight server that other features can use for testing over HTTP protocol. zPages HTTP is currently derived using this to serve files and communicate data. This is not meant for production use, as it doesn't implement HTTPS.
Furthermore, future patches will add additional thread safety and the directory storing these files will be less nested