Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[configopaque, confmap] Change yaml test by confmap test #9442

Merged

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jan 31, 2024

Description:

  • Remove yaml test from configopaque
  • Add test in confmap testing configopaque

Link to tracking Issue: From discussion on #9427

@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 31, 2024
@mx-psi mx-psi marked this pull request as ready for review January 31, 2024 12:52
@mx-psi mx-psi requested review from a team and dmitryax January 31, 2024 12:52
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (203ae9b) 90.25% compared to head (c55a231) 90.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9442      +/-   ##
==========================================
- Coverage   90.25%   90.24%   -0.02%     
==========================================
  Files         344      344              
  Lines       17932    17932              
==========================================
- Hits        16185    16182       -3     
- Misses       1419     1421       +2     
- Partials      328      329       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cmd/mdatagen/go.mod Outdated Show resolved Hide resolved
@mx-psi
Copy link
Member Author

mx-psi commented Jan 31, 2024

It seems like you both agree on doing it the other way around. I prefer doing it this way but don't feel strongly about it, and we can always change it after the fact, so let me fix it :)

@mx-psi mx-psi changed the title [configopaque, confmap] Move tests around [configopaque, confmap] Change yaml test by confmap test Jan 31, 2024
Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly the more I think of it, this really ought to be an integration test somewhere else in the repo. What we're really checking is that both the config packages and confmap use the same encoding interfaces when neither depends on the other.

That said, this looks good to me.

@mx-psi
Copy link
Member Author

mx-psi commented Feb 1, 2024

Honestly the more I think of it, this really ought to be an integration test somewhere else in the repo. What we're really checking is that both the config packages and confmap use the same encoding interfaces when neither depends on the other.

That makes sense to me. I think for now we can go down this route since this is the status quo and changing this is not a breaking change

@bogdandrutu bogdandrutu merged commit cc7265d into open-telemetry:main Feb 1, 2024
42 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants