Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed indentation in YAML for deployment at otel-config.yaml #9311

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

joseg2
Copy link
Contributor

@joseg2 joseg2 commented Jan 18, 2024

The name/value entry had an incorrect indentation that made the documented process fail (Document ref: https://opentelemetry.io/docs/collector/installation/)

Important (read before submitting)

We are currently preparing for the upcoming 1.0 GA release. Pull requests that are not aligned with
the current roadmap and are not aimed at stabilizing and preparing the Collector for the release will
not be accepted.

Delete the preceding paragraph before submitting.

Description:

Link to tracking Issue:

Testing:

Documentation:

Please delete paragraphs that you did not use before submitting.

The name/value entry had an incorrect indentation that made the documented process fail
(Document ref: https://opentelemetry.io/docs/collector/installation/)
@joseg2 joseg2 requested review from a team and bogdandrutu January 18, 2024 05:11
Copy link

linux-foundation-easycla bot commented Jan 18, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@joseg2
Copy link
Contributor Author

joseg2 commented Jan 18, 2024

Currently, the following error occurs when running kubectl apply
$ kubectl apply -f otel-config.yaml configmap/otel-agent-conf created daemonset.apps/otel-agent created configmap/otel-collector-conf created service/otel-collector created error: error parsing otel-config.yaml: error converting YAML to JSON: yaml: line 49: mapping values are not allowed in this context
Once the indentation is corrected, the kubectl apply creates the deployment with no issues

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joseg2!

@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 18, 2024
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c1599fe) 90.36% compared to head (4b6be5e) 90.36%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9311   +/-   ##
=======================================
  Coverage   90.36%   90.36%           
=======================================
  Files         340      340           
  Lines       17987    17987           
=======================================
  Hits        16254    16254           
  Misses       1410     1410           
  Partials      323      323           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeboten codeboten merged commit 2370481 into open-telemetry:main Jan 18, 2024
33 of 35 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 18, 2024
TylerHelmuth pushed a commit to TylerHelmuth/opentelemetry-collector that referenced this pull request Jan 23, 2024
…lemetry#9311)

The name/value entry had an incorrect indentation that made the
documented process fail (Document ref:
https://opentelemetry.io/docs/collector/installation/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants