Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Clarify configopaque expectations #9295

Merged

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jan 16, 2024

Description:

Documents configopaque expectations.

The intention is that it is clear that we can add interface implementations after 1.0 if not doing so would leak opaque values.

Link to tracking Issue: Fixes #9274

@mx-psi mx-psi requested review from a team and Aneurysm9 January 16, 2024 13:36
@mx-psi mx-psi requested a review from bogdandrutu January 16, 2024 13:38
@mx-psi
Copy link
Member Author

mx-psi commented Jan 16, 2024

cc @TylerHelmuth

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (440bb82) 90.31% compared to head (27010a1) 90.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9295      +/-   ##
==========================================
+ Coverage   90.31%   90.33%   +0.01%     
==========================================
  Files         341      341              
  Lines       18308    18308              
==========================================
+ Hits        16535    16538       +3     
+ Misses       1437     1435       -2     
+ Partials      336      335       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeboten codeboten merged commit 3a16592 into open-telemetry:main Jan 16, 2024
32 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document configopaque security expectations
4 participants