Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move contract test out of component #9140

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Dec 19, 2023

Description:
remove dependency of otlphttpreceiver on otlpexporter

Link to tracking Issue:
Fixes #6454

@atoulme atoulme requested review from a team and jpkrohling December 19, 2023 02:52
@atoulme atoulme force-pushed the fix_dependency_otlpreceiver_otlpexporter branch 3 times, most recently from 98b3a83 to 7b71e64 Compare December 19, 2023 04:21
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a7dc838) 91.47% compared to head (ba1f5d1) 91.41%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9140      +/-   ##
==========================================
- Coverage   91.47%   91.41%   -0.07%     
==========================================
  Files         320      320              
  Lines       17187    17187              
==========================================
- Hits        15722    15711      -11     
- Misses       1165     1173       +8     
- Partials      300      303       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atoulme atoulme force-pushed the fix_dependency_otlpreceiver_otlpexporter branch from d587f57 to 67c152f Compare December 19, 2023 04:46
@atoulme atoulme force-pushed the fix_dependency_otlpreceiver_otlpexporter branch from 3d73fee to 3f9e850 Compare December 19, 2023 18:44
internal/e2e/go.mod Show resolved Hide resolved
@atoulme atoulme force-pushed the fix_dependency_otlpreceiver_otlpexporter branch from 3f9e850 to e4c5ef6 Compare December 19, 2023 18:50
@atoulme atoulme force-pushed the fix_dependency_otlpreceiver_otlpexporter branch from e4c5ef6 to 4584126 Compare December 19, 2023 18:51
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! this is great, thanks @atoulme

@codeboten
Copy link
Contributor

Replace statements are out of date, please run "make crosslink" and commit the changes in this PR.

@atoulme
Copy link
Contributor Author

atoulme commented Dec 19, 2023

good to go

@bogdandrutu bogdandrutu merged commit 9f0c9e1 into open-telemetry:main Dec 19, 2023
32 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove otlphttpreceiver dependency from otlpexporter
3 participants