refactor(builder): change output of version subcommand.
#8994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
reviewed
Nov 27, 2023
If version information has not been inserted by `ldflags`, the build information embedded in the binary being executed is output. Return an error when failing to retrieve the version, and to use cobra's `RunE`.
devoc09
force-pushed
the
output_version_of_binary
branch
from
30d0ed0 to
d0953f9
Compare
|
I have combined the commits into one and pushed it, so please check again. |
bogdandrutu
approved these changes
Dec 6, 2023
|
Please add a changelog entry. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8994 +/- ##
==========================================
- Coverage 91.56% 91.49% -0.07%
==========================================
Files 316 316
Lines 17168 17181 +13
==========================================
Hits 15720 15720
- Misses 1152 1165 +13
Partials 296 296 ☔ View full report in Codecov by Sentry. |
devoc09
force-pushed
the
output_version_of_binary
branch
from
083e307 to
1759818
Compare
Added changelog. Please review again 🙏 |
TylerHelmuth
reviewed
Dec 7, 2023
TylerHelmuth
approved these changes
Dec 8, 2023
jackgopack4
pushed a commit
to jackgopack4/opentelemetry-collector
that referenced
this pull request
Oct 8, 2024
…ing (open-telemetry#11261) This has been fixed since v0.91.0: open-telemetry#8994.
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Dec 19, 2024
…ing (open-telemetry#11261) This has been fixed since v0.91.0: open-telemetry#8994.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, running
builder versionon binaries installed withgo installwill output the version specified at the suffix.If it's under development, the following output will be obtained.
Link to tracking Issue: #8770