Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] consistently use multierr in otel instatiation #8376

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

codeboten
Copy link
Contributor

This PR updates the instantation of otel instruments in the batch processor to use multierr instead of returning on the first error it encounters. This aligns w/ other places in the code where we instatiate otel instruments.

This PR updates the instantation of otel instruments
in the batch processor to use multierr instead of returning
on the first error it encounters. This aligns w/ other places
in the code where we instatiate otel instruments.

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten requested review from a team and Aneurysm9 September 7, 2023 20:40
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
processor/batchprocessor/metrics.go 100.00%

📢 Thoughts on this report? Let us know!.

@codeboten codeboten merged commit 03b56b6 into open-telemetry:main Sep 7, 2023
@codeboten codeboten deleted the codeboten/use-multierr branch September 7, 2023 21:17
@github-actions github-actions bot added this to the next release milestone Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants