Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component Status Reporting #8169

Merged
merged 40 commits into from
Oct 6, 2023
Merged
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
1115e9d
Introduce component status reporting
tigrannajaryan Nov 15, 2022
897ebf8
Get things working after rebase
mwear Aug 1, 2023
a98e35b
Add changelog
mwear Aug 2, 2023
1e77eb5
Lint
mwear Aug 2, 2023
8cf3ece
Implement and use component.GlobalID in place of component.StatusSource
mwear Aug 2, 2023
35e703f
Replace GlobalID with InstanceID
mwear Aug 15, 2023
124d20e
Status implemented as a finite state machine
mwear Aug 22, 2023
dd19267
Add ReportFatalError behavior to ReportComponentStatus
mwear Aug 24, 2023
0d954fd
Improved testing; cleanup
mwear Aug 24, 2023
b45540e
Move ReportComponentStatus from Host to TelemetrySettings
mwear Aug 30, 2023
2f0f54e
Share state machines between component and service versionss of Repor…
mwear Sep 8, 2023
e690b51
Automatically report status during startup/shutdown
mwear Sep 9, 2023
9bba9be
StatusFunc improvements
mwear Sep 10, 2023
7d08aa5
Cleanup
mwear Sep 10, 2023
7f35ad5
Do not automatically report StatusOK during startup
mwear Sep 11, 2023
26e59f1
Refactor instanceID creation
mwear Sep 14, 2023
67676a4
More accurate comments
mwear Sep 14, 2023
e0a891e
Fix state transitions to StatusStopped
mwear Sep 14, 2023
a0c106c
Remove functional options; replace with per-error type event construc…
mwear Sep 15, 2023
ec257c6
Do not return errors from StatusWatchers
mwear Sep 15, 2023
2754546
Rename servicetelemetry.Settings to servicetelemetry.TelemetrySettings
mwear Sep 15, 2023
f1c678f
Fix typo in component/status.go
mwear Sep 15, 2023
ed88afd
Handle ReportComponentStatus for SharedComponents
mwear Sep 15, 2023
22f2c40
Implement AggregateStatus to compute an effective status from a map o…
mwear Sep 16, 2023
362e1ab
Add additional utility methods for component status and events
mwear Sep 17, 2023
f821467
Automatically report status for extensions during startup/shutdown
mwear Sep 17, 2023
178f885
Replace LastErrorEvent with more flexible LastEventByStatus
mwear Sep 17, 2023
6f265c1
Add component.EffectiveStatus method
mwear Sep 18, 2023
20bd41d
Fix out of date comment
mwear Sep 20, 2023
bed7e50
Rename EffectiveStatus to AggregateStatusEvent; add more comments
mwear Sep 20, 2023
5cb9626
Fix flaky test
mwear Sep 20, 2023
e4fb9ac
Correct comments in component/telemetry.go
mwear Sep 27, 2023
59ad517
Improve comments
mwear Sep 29, 2023
0a646ad
Move StatusWatcher interface to extension package
mwear Sep 29, 2023
4ada43f
Reduce public API for event utility methods
mwear Sep 29, 2023
9f0811f
Update comment in component/status.go
mwear Oct 3, 2023
9455b7f
Fix automatic status reporting for SharedComponents
mwear Oct 5, 2023
5361925
Update version in deprecation comments
mwear Oct 5, 2023
711fb73
Streamline error assertions
mwear Oct 5, 2023
6e09fb0
Fix test post rebase
mwear Oct 6, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Correct comments in component/telemetry.go
Co-authored-by: Evan Bradley <[email protected]>
  • Loading branch information
mwear and evan-bradley committed Oct 6, 2023
commit e4fb9acff15d09805ea76e034e22a06ea691ba7a
2 changes: 1 addition & 1 deletion component/telemetry.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ type TelemetrySettingsBase[T any] struct {
// ReportComponentStatus allows a component to report runtime changes in status. The service
// will automatically report status for a component during startup and shutdown. Components can
// use this method to report status after start and before shutdown. ReportComponentStatus
// will only return errors if the API used incorrectly. The three scenarios where an error will
// will only return errors if the API used incorrectly. The two scenarios where an error will
// be returned are:
//
// - An illegal state transition
Expand Down