Update prepare-release.yml #8135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validate version format in release workflow
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #8135 +/- ##
==========================================
+ Coverage 90.23% 90.25% +0.01%
==========================================
Files 301 301
Lines 15551 15551
==========================================
+ Hits 14033 14035 +2
+ Misses 1228 1227 -1
+ Partials 290 289 -1 ☔ View full report in Codecov by Sentry. |
mx-psi
reviewed
Jul 26, 2023
Co-authored-by: Pablo Baeyens <[email protected]>
mx-psi
approved these changes
Jul 31, 2023
|
|
||
| # Check if candidate-stable matches the version pattern. | ||
| if ! [[ "${{ inputs.candidate-stable }}" =~ $version_pattern ]]; then | ||
| echo "Invalid candidate-stable version format! Expected format: x.y.z or x.y.z-rcn" |
There was a problem hiding this comment.
Suggested change
| echo "Invalid candidate-stable version format! Expected format: x.y.z or x.y.z-rcn" | |
| echo "Invalid candidate-stable version format! Expected format: x.y.z, x.y.z-rcN or x.y.z-rcvN" |
|
|
||
| # Check if current-stable matches the version pattern. | ||
| if ! [[ "${{ inputs.current-stable }}" =~ $version_pattern ]]; then | ||
| echo "Invalid current-stable version format! Expected format: x.y.z or x.y.z-rcn" |
There was a problem hiding this comment.
Suggested change
| echo "Invalid current-stable version format! Expected format: x.y.z or x.y.z-rcn" | |
| echo "Invalid current-stable version format! Expected format: x.y.z, x.y.z-rcN or x.y.z-rcvN" |
|
|
||
| # Check if candidate-beta matches the version pattern. | ||
| if ! [[ "${{ inputs.candidate-beta }}" =~ $version_pattern ]]; then | ||
| echo "Invalid candidate-beta version format! Expected format: x.y.z or x.y.z-rcn" |
There was a problem hiding this comment.
Suggested change
| echo "Invalid candidate-beta version format! Expected format: x.y.z or x.y.z-rcn" | |
| echo "Invalid candidate-beta version format! Expected format: x.y.z, x.y.z-rcN or x.y.z-rcvN |
|
|
||
| # Check if current-beta matches the version pattern. | ||
| if ! [[ "${{ inputs.current-beta }}" =~ $version_pattern ]]; then | ||
| echo "Invalid current-beta version format! Expected format: x.y.z or x.y.z-rcn" |
There was a problem hiding this comment.
Suggested change
| echo "Invalid current-beta version format! Expected format: x.y.z or x.y.z-rcn" | |
| echo "Invalid current-beta version format! Expected format: x.y.z, x.y.z-rcN or x.y.z-rcvN |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate version format in release workflow
Description:
The changes made in prepare-release.yml is made to validate the version format using a bash script.
Any suggestions will be appreciated.
Link to tracking Issue: #7627