Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validate command to validate collector config #7835

Merged

Conversation

codeboten
Copy link
Contributor

This is bringing back the functionality initially submitted in @Chinwendu20's PR: #6445

Adds a validate method which validates the configuration

Link to tracking Issue: #4613

@codeboten codeboten requested review from a team and bogdandrutu June 6, 2023 18:17
Copy link
Contributor

@jmacd jmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch coverage: 77.41% and project coverage change: +0.27 🎉

Comparison is base (897a316) 90.82% compared to head (8bccc7f) 91.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7835      +/-   ##
==========================================
+ Coverage   90.82%   91.09%   +0.27%     
==========================================
  Files         296      297       +1     
  Lines       14840    14831       -9     
==========================================
+ Hits        13478    13511      +33     
+ Misses       1087     1044      -43     
- Partials      275      276       +1     
Impacted Files Coverage Δ
otelcol/command_validate.go 70.83% <70.83%> (ø)
otelcol/collector.go 78.72% <100.00%> (+0.94%) ⬆️
otelcol/command.go 82.14% <100.00%> (+0.66%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jpkrohling
Copy link
Member

@Chinwendu20, would you like to review this one as well?

@codeboten codeboten force-pushed the add-dry-run-flag-validate-all-fields branch from 50d458e to 8763735 Compare June 7, 2023 18:15
@Chinwendu20
Copy link
Contributor

Thanks for continuing with the PR, looks good to me.

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten merged commit 463711f into open-telemetry:main Jun 7, 2023
@codeboten codeboten deleted the add-dry-run-flag-validate-all-fields branch June 7, 2023 20:12
@github-actions github-actions bot added this to the next release milestone Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants