-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix undefined symbol errors on building otelcorecol for Plan 9 #6924
Conversation
|
c03b161
to
30939a1
Compare
Codecov ReportBase: 91.05% // Head: 91.08% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6924 +/- ##
==========================================
+ Coverage 91.05% 91.08% +0.03%
==========================================
Files 237 238 +1
Lines 14298 14418 +120
==========================================
+ Hits 13019 13133 +114
- Misses 1027 1033 +6
Partials 252 252
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lufia, thanks for the PR. While we don't currently have a well defined policy on when/how to add support to new OS or architectures, I personally would be fine accepting this change with the understanding that
- we can't ensure we won't break the Plan 9 build in the future
- we probably will not be able to address any bug reports that are Plan 9 specific
- we won't provide official builds or run the test suite on CI for Plan 9
- a Plan 9 build may not have feature parity with our official builds
- If there are issues that interfere with development we may need to remove support for Plan 9 entirely if we don't get help from you or other contributors
(where 'we' here is to be understood as 'the current OTel Collector community')
The above is my personal take on this, other contributors may disagree. I can work on getting agreement from the community and making this informal policy more well defined if this seems acceptable to you.
30939a1
to
9879a6c
Compare
Hi @mx-psi thank you for your review! I have agree all of them. I'd like to serve otelcontribcol service in my own Plan 9 box so far. I would make an effort to keep Plan 9 build healthy as far as I possible so please feel free to tell me if someone notices any issues in the future. |
9879a6c
to
a8af06c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐰 🧑🚀
Thats glenda! |
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
//go:build plan9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be "other" file and have the rule !linux && !darwin?
Description:
Building otelcorecol was broken for Plan 9.
Testing:
Though I'm not sure yet there are more other issues when otelcorecol is running on Plan 9, at least, this PR is fixed undefined symbol errors and I checked otelcorecol shows a help successfully with
-h
option.