Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[component] Rename "In development" stability level to "Development" #6561

Merged

Conversation

dmitryax
Copy link
Member

The decision to rename this stability level was made in #6531 (comment)

@dmitryax dmitryax requested review from a team and Aneurysm9 November 15, 2022 23:23
@dmitryax dmitryax force-pushed the rename-dev-stability-level branch 2 times, most recently from a94f63d to e7c0a86 Compare November 15, 2022 23:28
@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Base: 91.12% // Head: 91.12% // No change to project coverage 👍

Coverage data is based on head (23d20b3) compared to base (65dfc32).
Patch coverage: 71.42% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6561   +/-   ##
=======================================
  Coverage   91.12%   91.12%           
=======================================
  Files         241      241           
  Lines       13887    13887           
=======================================
  Hits        12654    12654           
  Misses        993      993           
  Partials      240      240           
Impacted Files Coverage Δ
service/internal/components/components.go 100.00% <ø> (ø)
...ervice/internal/testcomponents/example_exporter.go 100.00% <ø> (ø)
...rvice/internal/testcomponents/example_processor.go 100.00% <ø> (ø)
...ervice/internal/testcomponents/example_receiver.go 100.00% <ø> (ø)
component/component.go 62.22% <50.00%> (ø)
exporter/loggingexporter/factory.go 88.88% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dmitryax
Copy link
Member Author

To fix failing contrib-tests #6563

@@ -71,7 +71,7 @@ we intend to provide high-quality components as part of this repository, we ackn
for prime time. As such, each component should list its current stability level for each telemetry signal, according to
the following definitions:

### In development
### Development
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rename will break a lot of links in contrib right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll fix them once this is merged

@bogdandrutu
Copy link
Member

Look at the errors:

Error: /home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/loggingexporter/factory.go:46:64: undefined: component.StabilityLevelDevelopment
Error: /home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/loggingexporter/factory.go:47:66: undefined: component.StabilityLevelDevelopment
Error: /home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/loggingexporter/factory.go:48:60: undefined: component.StabilityLevelDevelopment

Something is wrong with cross links

@bogdandrutu
Copy link
Member

Needs a rebase

@dmitryax dmitryax force-pushed the rename-dev-stability-level branch from e7c0a86 to d21c7f5 Compare November 16, 2022 04:39
@dmitryax
Copy link
Member Author

Rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants