Deprecate all update funcs, easy to replace with Get and mutate result. #6013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 92.17% // Head: 92.17% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #6013 +/- ##
=======================================
Coverage 92.17% 92.17%
=======================================
Files 212 212
Lines 13266 13266
=======================================
Hits 12228 12228
Misses 820 820
Partials 218 218
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dmitryax
approved these changes
Sep 1, 2022
|
Please update changelog |
Signed-off-by: Bogdan <[email protected]>
bogdandrutu
force-pushed
the
deprecateallupdate
branch
from
bdc591a to
831807c
Compare
This was referenced Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #5998
Signed-off-by: Bogdan [email protected]