Define a new API for components stability level to match extensions as well #5762
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5762 +/- ##
=======================================
Coverage ? 91.59%
=======================================
Files ? 192
Lines ? 11473
Branches ? 0
=======================================
Hits ? 10509
Misses ? 770
Partials ? 194
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Looking for feedback on this PR, before I will do the changelog and other changes. |
| @@ -31,7 +31,7 @@ const ( | |||
|
|
|||
| // NewFactory creates a factory for Z-Pages extension. | |||
| func NewFactory() component.ExtensionFactory { | |||
| return component.NewExtensionFactory(typeStr, createDefaultConfig, createExtension) | |||
| return component.NewExtensionFactoryWithStabilityLevel(typeStr, createDefaultConfig, createExtension, component.StabilityLevelBeta) | |||
There was a problem hiding this comment.
This is fine for this PR, but perhaps we should try to have consumers changed in a follow-up PR. This would help assert that the changes are indeed backward compatible. This did leave me wondering if a similar change wouldn't be needed in the other components from this repo, like the OTLP receiver/exporter.
There was a problem hiding this comment.
Receivers, processors, and exporters have already had stability levels added in an earlier change. Extension were the only components left out from my earlier change
bogdandrutu
force-pushed
the
stability
branch
3 times, most recently
from
ac1a6b5 to
35c0a1b
Compare
…s well Signed-off-by: Bogdan <[email protected]>
StabilityLevel(config.DataType)function from the baseFactorywhich is not well suited for Extension.Stabilityfunctions.Signed-off-by: Bogdan [email protected]