Move service.mapResolver to confmap.Resolver #5444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5444 +/- ##
==========================================
- Coverage 90.92% 90.88% -0.04%
==========================================
Files 191 191
Lines 11424 11421 -3
==========================================
- Hits 10387 10380 -7
- Misses 817 820 +3
- Partials 220 221 +1
Continue to review full report at Codecov.
|
bogdandrutu
force-pushed
the
mapresolver
branch
2 times, most recently
from
144a8f4 to
7ff887c
Compare
The reason to do this is to allow alternative implementation of the service.ConfigProvider to re-use the resolver logic, also to create an independent "confmap.Conf" resolver for other services/binaries to use. Signed-off-by: Bogdan Drutu <[email protected]>
codeboten
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason to do this is to allow alternative implementation of the service.ConfigProvider to re-use the resolver logic,
also to create an independent "confmap.Conf" resolver for other services/binaries to use.
Signed-off-by: Bogdan Drutu [email protected]