Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move semconv package from pdata to its own module #5196

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Move semconv package from pdata to its own module #5196

merged 1 commit into from
Apr 14, 2022

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Apr 12, 2022 •
edited
Loading

  • Copy model/semconv package to a new semconv module
  • Add deprecation notices to API from model/semconv

Resolves #5195

@dmitryax dmitryax requested review from a team and Aneurysm9 April 12, 2022 21:50
@codecov
Copy link

codecov bot commented Apr 12, 2022 •
edited
Loading

Codecov Report

Merging #5196 (ef1616c) into main (098389e) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5196      +/-   ##
==========================================
- Coverage   90.39%   90.36%   -0.04%     
==========================================
  Files         187      187              
  Lines       11062    11062              
==========================================
- Hits        10000     9996       -4     
- Misses        839      842       +3     
- Partials      223      224       +1
Impacted Files Coverage Δ
service/telemetry.go 76.25% <ø> (ø)
pdata/internal/common.go 94.16% <0.00%> (-0.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 098389e...ef1616c. Read the comment docs.

@dmitryax dmitryax force-pushed the move-semconv branch 3 times, most recently from 5eae701 to 49541c8 Compare April 13, 2022 00:04
@bogdandrutu
Copy link
Member

Please rebase

@dmitryax
Move semconv package from pdata to its own module
ef1616c 
- Move `model/semconv` package to a new `semconv` module
- Add deprecation notices to API from `model/semconv`
@bogdandrutu bogdandrutu merged commit b287063 into open-telemetry:main Apr 14, 2022
@dmitryax dmitryax deleted the move-semconv branch April 15, 2022 00:19
Nicholaswang pushed a commit to Nicholaswang/opentelemetry-collector that referenced this pull request Jun 7, 2022
@dmitryax @Nicholaswang
Move semconv package from pdata to its own module (open-telemetry#5196)
552d60b 
- Move `model/semconv` package to a new `semconv` module
- Add deprecation notices to API from `model/semconv`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move model/semconv to a new dedicated module semconv
2 participants
@dmitryax @bogdandrutu