Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated NewConfigProvider funcs #4937

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Mar 1, 2022

This PR does not add the new versions of the NewConfigProvider since we are still designing/reviewing that change.

The proposal for the new version is in #4936 but that will take time to review.

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested review from a team and tigrannajaryan March 1, 2022 23:52
This PR does not add the new versions of the `NewConfigProvider` since we are still designing/reviewing that change.

Signed-off-by: Bogdan Drutu <[email protected]>
@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #4937 (85255f8) into main (73a30a6) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4937      +/-   ##
==========================================
+ Coverage   90.85%   91.02%   +0.17%     
==========================================
  Files         178      178              
  Lines       10594    10597       +3     
==========================================
+ Hits         9625     9646      +21     
+ Misses        753      734      -19     
- Partials      216      217       +1     
Impacted Files Coverage Δ
service/config_provider.go 94.17% <100.00%> (-0.22%) ⬇️
config/configtelemetry/configtelemetry.go 90.32% <0.00%> (ø)
service/telemetry.go 76.25% <0.00%> (+14.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73a30a6...85255f8. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 5f2d874 into open-telemetry:main Mar 2, 2022
@bogdandrutu bogdandrutu deleted the rmdeprcfgprovider branch March 2, 2022 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants