Adjust default retry settings for the PRW Exporter #3416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Aneurysm9 @odeke-em can you review too? |
alolita
approved these changes
Jun 10, 2021
Aneurysm9
approved these changes
Jun 10, 2021
The default retry settings are far off from the Prometheus Server's behavior. Retry more aggressively to avoid excessive in-memory buffering. Also fixes open-telemetry/prometheus-interoperability-spec#54 because the test times out before the retry is sent.
bogdandrutu
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default retry settings are far off from the Prometheus
Server's behavior. Retry more aggressively to avoid excessive
in-memory buffering.
Fixes open-telemetry/prometheus-interoperability-spec#54 because the test
times out before the retry is sent.