Enable the queue for the Prometheus Remote Write Exporter internally #2974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow up to #2951. When we disable the queue completely, it causes the export to happen not in a consumer goroutine. Enable the queue internally that export gets its own goroutine not to block the entire collector pipeline.
|
cc @bogdandrutu |
bogdandrutu
reviewed
Apr 21, 2021
Codecov Report
@@ Coverage Diff @@
## main #2974 +/- ##
=======================================
Coverage 91.64% 91.64%
=======================================
Files 312 312
Lines 15414 15419 +5
=======================================
+ Hits 14126 14131 +5
Misses 881 881
Partials 407 407
Continue to review full report at Codecov.
|
rakyll
changed the title
bogdandrutu
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #2951.
When we disable the queue completely, it causes the export to happen
not in a consumer goroutine. Enable the queue internally that export
gets its own goroutine not to block the entire collector pipeline.