Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logs support on Kafka exporter #2943

Merged
merged 3 commits into from
Apr 20, 2021

Conversation

sincejune
Copy link
Contributor

@sincejune sincejune commented Apr 15, 2021

Description:
Add logs support on Kafka exporter

Link to tracking Issue:
Related to #1331
Related to open-telemetry/opentelemetry-collector-contrib#268

Testing:

  • Added corresponding unit tests according to traces and metrics.
  • Tested locally with Kafka 2.11-2.0.0

Documentation:
Update Kafka exporter README and Exporter README.

@sincejune sincejune requested a review from a team April 15, 2021 07:23
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 15, 2021

CLA Signed

The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #2943 (aa39026) into main (90b2dec) will increase coverage by 0.01%.
The diff coverage is 95.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2943      +/-   ##
==========================================
+ Coverage   91.58%   91.59%   +0.01%     
==========================================
  Files         312      312              
  Lines       15351    15397      +46     
==========================================
+ Hits        14059    14103      +44     
- Misses        883      884       +1     
- Partials      409      410       +1     
Impacted Files Coverage Δ
exporter/kafkaexporter/otlp_marshaller.go 60.00% <60.00%> (ø)
exporter/kafkaexporter/factory.go 100.00% <100.00%> (ø)
exporter/kafkaexporter/kafka_exporter.go 100.00% <100.00%> (ø)
exporter/kafkaexporter/marshaller.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90b2dec...aa39026. Read the comment docs.

@@ -24,6 +24,7 @@ Available log exporters (sorted alphabetically):

- [OTLP gRPC](otlpexporter/README.md)
- [OTLP HTTP](otlphttpexporter/README.md)
- [Kafka](kafkaexporter/README.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this to metrics as well :)

@bogdandrutu bogdandrutu merged commit 5e14135 into open-telemetry:main Apr 20, 2021
@sincejune sincejune deleted the kafka-logs-exporter branch April 21, 2021 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants