Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove config.NewViper, users should use config.NewParser #2917

Merged
merged 3 commits into from
Apr 13, 2021
Merged

Remove config.NewViper, users should use config.NewParser #2917

merged 3 commits into from
Apr 13, 2021

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Apr 13, 2021 •
edited
Loading

Updates #2651

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested a review from a team April 13, 2021 00:01
@codecov
Copy link

codecov bot commented Apr 13, 2021 •
edited
Loading

Codecov Report

Merging #2917 (5589354) into main (700a7b1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2917   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files         312      312           
  Lines       15349    15349           
=======================================
  Hits        14067    14067           
  Misses        874      874           
  Partials      408      408
Impacted Files Coverage Δ
config/parser.go 78.84% <100.00%> (ø)
service/parserprovider/setflag.go 73.91% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 700a7b1...5589354. Read the comment docs.

@bogdandrutu bogdandrutu changed the title Remove config.NewViper, users should use config.Parser Remove config.NewViper, users should use config.NewParser Apr 13, 2021
@bogdandrutu
Update changelog
4c9d4b8 
Signed-off-by: Bogdan Drutu <[email protected]>
@bogdandrutu bogdandrutu merged commit b428785 into open-telemetry:main Apr 13, 2021
@bogdandrutu bogdandrutu deleted the rmnewviper branch April 13, 2021 19:04
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
@atoulme
Add shutdown method to hostmetadata monitor (open-telemetry#2917)
44d9be7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@mx-psi mx-psi mx-psi approved these changes

@pjanotti pjanotti pjanotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bogdandrutu @tigrannajaryan @mx-psi @pjanotti