-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put HTTP headers into context in Jaeger Thrift receiver #2407
Put HTTP headers into context in Jaeger Thrift receiver #2407
Conversation
Signed-off-by: Pavol Loffay <[email protected]>
@bogdandrutu @tigrannajaryan could you please review? |
Codecov Report
@@ Coverage Diff @@
## master #2407 +/- ##
=======================================
Coverage 91.91% 91.92%
=======================================
Files 270 270
Lines 15297 15302 +5
=======================================
+ Hits 14061 14066 +5
Misses 857 857
Partials 379 379
Continue to review full report at Codecov.
|
FYI in the meantime, we have applied the patch to our fork to unblock us hypertrace/hypertrace-collector#23. It would be great to move this PR to decrease maintenance pain. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure which headers do you need access to, but there are some information we add related to tenant id (https://github.com/open-telemetry/opentelemetry-collector/blob/main/client/client.go), also there is this discussion #2495
The problem with context is that we drop it in processors like batch.
It's is not an issue for us since we access the headers in the first processor in the pipeline. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
any update on this @bogdandrutu ? |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Signed-off-by: Pavol Loffay [email protected]
Description:
Put HTTP headers in Jaeger receiver into context object. I need to access haeders in a custom processor to attach tenant ID into span attributes and calculate some metrics.
Also https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/master/processor/routingprocessor uses metadata to access tenant ID header.
Link to tracking Issue:
Resolves #2401