Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fluentforwardreceiver config example #2157

Conversation

gramidt
Copy link
Member

@gramidt gramidt commented Nov 14, 2020

Description:
Fixed fluentforwardreceiver example configuration. The example configuration specified listenerAddress; however, it should be endpoint based on the Config struct.

Testing:
Configured fluentforwardreceiver and specified the correct configuration based on the Config struct.

Documentation:
See commit.

@gramidt gramidt requested a review from a team November 14, 2020 22:48
@codecov
Copy link

codecov bot commented Nov 14, 2020

Codecov Report

Merging #2157 (c1af511) into master (6ac579e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2157   +/-   ##
=======================================
  Coverage   92.22%   92.22%           
=======================================
  Files         280      280           
  Lines       16996    16996           
=======================================
  Hits        15674    15674           
  Misses        906      906           
  Partials      416      416           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ac579e...c1af511. Read the comment docs.

Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@bogdandrutu bogdandrutu merged commit 9bf7885 into open-telemetry:master Nov 15, 2020
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
…ry#2157)

Bumps [github.com/hashicorp/vault/api](https://github.com/hashicorp/vault) from 1.8.0 to 1.8.1.
- [Release notes](https://github.com/hashicorp/vault/releases)
- [Changelog](https://github.com/hashicorp/vault/blob/main/CHANGELOG.md)
- [Commits](hashicorp/vault@v1.8.0...v1.8.1)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/vault/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants