Remove ConsumerOld #1631
Merged
Remove ConsumerOld #1631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
bogdandrutu
force-pushed
the
rmconsold
branch
2 times, most recently
from
a0e3a25 to
028d3d9
Compare
james-bebbington
approved these changes
Aug 25, 2020
Codecov Report
@@ Coverage Diff @@
## master #1631 +/- ##
==========================================
- Coverage 91.89% 91.88% -0.01%
==========================================
Files 255 254 -1
Lines 17510 17309 -201
==========================================
- Hits 16090 15905 -185
+ Misses 1013 1007 -6
+ Partials 407 397 -10
Continue to review full report at Codecov.
|
Signed-off-by: Bogdan Drutu <[email protected]>
james-bebbington
force-pushed
the
rmconsold
branch
from
028d3d9 to
faaf4e5
Compare
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* sdk/trace: add missing options to tracer provider This change adds `WithDefaultSampler` and `WithSpanLimits` to the tracer provider and removed `WithConfig` from it. Before this change, `WithConfig` is the only way to set sampler or limits of a span. However, it is prone to misuse, since `WithConfig` can override tracing configurations that are configured by `WithResource` or `WithIDGenerator`. Thus to fix this, it adds new functional options - `WithDefaultSampler` and `WithSpanLimits` and removes `WithConfig`. Resolves open-telemetry#1631. * Update sdk/trace/provider.go Co-authored-by: Tyler Yahn <[email protected]> * Update sdk/trace/provider.go Co-authored-by: Tyler Yahn <[email protected]> * rebase and remove WithConfig Co-authored-by: Tyler Yahn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.