Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logs factories and merge with normal factories #1569

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu [email protected]

@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #1569 into master will decrease coverage by 0.03%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1569      +/-   ##
==========================================
- Coverage   91.92%   91.89%   -0.04%     
==========================================
  Files         254      254              
  Lines       17534    17536       +2     
==========================================
- Hits        16118    16114       -4     
- Misses       1011     1015       +4     
- Partials      405      407       +2     
Impacted Files Coverage Δ
component/componenttest/example_factories.go 88.81% <0.00%> (-1.12%) ⬇️
exporter/exporterhelper/factory.go 100.00% <ø> (ø)
processor/processorhelper/factory.go 100.00% <ø> (ø)
service/builder/exporters_builder.go 76.81% <100.00%> (ø)
service/builder/pipelines_builder.go 81.29% <100.00%> (-1.44%) ⬇️
service/builder/receivers_builder.go 74.21% <100.00%> (-1.26%) ⬇️
translator/internaldata/resource_to_oc.go 89.36% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15ede2d...0c61f40. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 4be72e8 into open-telemetry:master Aug 25, 2020
@bogdandrutu bogdandrutu deleted the logs branch August 25, 2020 01:47
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
* Stagger timestamps in exact aggregator tests

Fixes open-telemetry#1559.

* Missed one

* Yield while you wait

* Just sleep for a teeny tiny bit

* Oops, wrong PR in Changelog

* Make sure that *some* time passes

* Keep time comparisons relaxed
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants