Remove deprecated funcs #12304
Merged
Remove deprecated funcs #12304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing all v0.119.0 deprecated funcs. Signed-off-by: Alex Boten <[email protected]>
codeboten
requested review from
bogdandrutu,
dmitryax and
a team
as code owners
Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12304 +/- ##
==========================================
+ Coverage 91.35% 91.41% +0.05%
==========================================
Files 467 467
Lines 25801 25583 -218
==========================================
- Hits 23571 23387 -184
+ Misses 1812 1778 -34
Partials 418 418 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Alex Boten <[email protected]>
bogdandrutu
approved these changes
Feb 6, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 10, 2025
Missed by #12304, this variables can no longer be initialized so this becomes dead code. Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing all v0.119.0 deprecated funcs.