Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove derprecated NewLogs[Request]Exporter funcs #11661

Merged
merged 2 commits into from
Nov 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .chloggen/rm-dep-exporterhelper.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: breaking

# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
component: exporterhelper

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Remove derprecated NewLogs[Request]Exporter funcs

# One or more tracking issues or pull requests related to the change
issues: [11661]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:

# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: [api]
6 changes: 0 additions & 6 deletions exporter/exporterhelper/logs.go
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,6 @@ func NewLogs(
return NewLogsRequest(ctx, set, requestFromLogs(pusher), append(logsOpts, options...)...)
}

// Deprecated: [v0.112.0] use NewLogs.
var NewLogsExporter = NewLogs

// RequestFromLogsFunc converts plog.Logs data into a user-defined request.
// Experimental: This API is at the early stage of development and may change without backward compatibility
// until https://github.com/open-telemetry/opentelemetry-collector/issues/8122 is resolved.
Expand Down Expand Up @@ -148,9 +145,6 @@ func NewLogsRequest(
}, err
}

// Deprecated: [v0.112.0] use NewLogsRequest.
var NewLogsRequestExporter = NewLogsRequest

type logsExporterWithObservability struct {
internal.BaseRequestSender
obsrep *internal.ObsReport
Expand Down
6 changes: 0 additions & 6 deletions exporter/exporterhelper/metrics.go
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,6 @@ func NewMetrics(
return NewMetricsRequest(ctx, set, requestFromMetrics(pusher), append(metricsOpts, options...)...)
}

// Deprecated: [v0.112.0] use NewMetrics.
var NewMetricsExporter = NewMetrics

// RequestFromMetricsFunc converts pdata.Metrics into a user-defined request.
// Experimental: This API is at the early stage of development and may change without backward compatibility
// until https://github.com/open-telemetry/opentelemetry-collector/issues/8122 is resolved.
Expand Down Expand Up @@ -148,9 +145,6 @@ func NewMetricsRequest(
}, err
}

// Deprecated: [v0.112.0] use NewMetricsRequest.
var NewMetricsRequestExporter = NewMetricsRequest

type metricsSenderWithObservability struct {
internal.BaseRequestSender
obsrep *internal.ObsReport
Expand Down
6 changes: 0 additions & 6 deletions exporter/exporterhelper/traces.go
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,6 @@ func NewTraces(
return NewTracesRequest(ctx, set, requestFromTraces(pusher), append(tracesOpts, options...)...)
}

// Deprecated: [v0.112.0] use NewTraces.
var NewTracesExporter = NewTraces

// RequestFromTracesFunc converts ptrace.Traces into a user-defined Request.
// Experimental: This API is at the early stage of development and may change without backward compatibility
// until https://github.com/open-telemetry/opentelemetry-collector/issues/8122 is resolved.
Expand Down Expand Up @@ -148,9 +145,6 @@ func NewTracesRequest(
}, err
}

// Deprecated: [v0.112.0] use NewTracesRequest.
var NewTracesRequestExporter = NewTracesRequest

type tracesWithObservability struct {
internal.BaseRequestSender
obsrep *internal.ObsReport
Expand Down
Loading