[scraperhelper] deprecate NewObsReport, ObsReport, ObsReportSettings #10959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function doesn't appear used in any of the components in either core or contrib. Deprecating to remove the surface area of the package. Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
codeboten
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10959 +/- ##
==========================================
- Coverage 91.89% 91.86% -0.03%
==========================================
Files 411 411
Lines 19311 19330 +19
==========================================
+ Hits 17745 17758 +13
- Misses 1217 1221 +4
- Partials 349 351 +2 ☔ View full report in Codecov by Sentry. |
iblancasa
reviewed
Aug 26, 2024
| # Include 'user' if the change is relevant to end users. | ||
| # Include 'api' if there is a change to a library API. | ||
| # Default: '[user]' | ||
| change_logs: [] |
There was a problem hiding this comment.
Shouldn't this include api?
codeboten
commented
Aug 26, 2024
atoulme
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions and structs doesn't appear used in any of the components in either core or contrib. Deprecating to remove the surface area of the package.