-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[builder] fix the TestGenerateInvalidOutputPath #10595
[builder] fix the TestGenerateInvalidOutputPath #10595
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10595 +/- ##
=======================================
Coverage 92.38% 92.38%
=======================================
Files 403 403
Lines 18722 18722
=======================================
Hits 17296 17296
Misses 1066 1066
Partials 360 360 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @giesan
Signed-off-by: Andrej Giesbrecht <[email protected]>
c61b42a
to
1568f67
Compare
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Looks like this was dropped. Any reason it's not ready to merge? |
Not from my point of view. |
@open-telemetry/collector-contrib-maintainers this should be ready to merge |
If the test is executed with the
root
user, theTestGenerateInvalidOutputPath
test fails.The behaviour was noticed with a GitLab runner that was executed with root rights.
An attempt is made to create the directory
/:invalid
during the test.A user without root rights receives the message
cannot create directory '/:invalid': Permission denied
.In contrast, the
root
user can create the directory without any problems because this is a valid path.To correct the behaviour of the test, the path to
:/invalid
was adjusted.This is not a valid path under Windows or Linux.