Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[builder] fix the TestGenerateInvalidOutputPath #10595

Merged

Conversation

giesan
Copy link
Contributor

@giesan giesan commented Jul 11, 2024

If the test is executed with the root user, the TestGenerateInvalidOutputPath test fails.
The behaviour was noticed with a GitLab runner that was executed with root rights.

An attempt is made to create the directory /:invalid during the test.
A user without root rights receives the message cannot create directory '/:invalid': Permission denied.
In contrast, the root user can create the directory without any problems because this is a valid path.

To correct the behaviour of the test, the path to :/invalid was adjusted.
This is not a valid path under Windows or Linux.

@giesan giesan requested review from a team and djaglowski July 11, 2024 05:58
Copy link

linux-foundation-easycla bot commented Jul 11, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: giesan / name: Andrej Giesbrecht (1568f67)

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.38%. Comparing base (88349c8) to head (1568f67).
Report is 72 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10595   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files         403      403           
  Lines       18722    18722           
=======================================
  Hits        17296    17296           
  Misses       1066     1066           
  Partials      360      360           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atoulme atoulme added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 12, 2024
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @giesan

@atoulme atoulme added the ready-to-merge Code review completed; ready to merge by maintainers label Jul 20, 2024
@giesan giesan force-pushed the fix/test-generate-invalid-output-path branch from c61b42a to 1568f67 Compare July 23, 2024 09:00
Copy link
Contributor

github-actions bot commented Aug 7, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 7, 2024
@djaglowski
Copy link
Member

Looks like this was dropped. Any reason it's not ready to merge?

@github-actions github-actions bot removed the Stale label Aug 8, 2024
@giesan
Copy link
Contributor Author

giesan commented Aug 8, 2024

Not from my point of view.

@djaglowski
Copy link
Member

@open-telemetry/collector-contrib-maintainers this should be ready to merge

@mx-psi mx-psi merged commit b521ed4 into open-telemetry:main Aug 8, 2024
52 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 8, 2024
@giesan giesan deleted the fix/test-generate-invalid-output-path branch August 18, 2024 19:10
@giesan giesan restored the fix/test-generate-invalid-output-path branch August 20, 2024 07:15
@giesan giesan deleted the fix/test-generate-invalid-output-path branch August 20, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants