Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[configauth] Deprecate GetClientAuthenticatorContext and GetServerAuthenticatorContext #10578

Conversation

TylerHelmuth
Copy link
Member

@TylerHelmuth TylerHelmuth commented Jul 9, 2024

Description

Deprecates GetClientAuthenticatorContext and GetServerAuthenticatorContext.

Link to tracking issue

Related to #9808

@TylerHelmuth TylerHelmuth requested review from a team and djaglowski July 9, 2024 21:20
@TylerHelmuth TylerHelmuth force-pushed the configauth-removed-deprecated-funcs branch from e54de4a to 35eb7c9 Compare July 9, 2024 21:25
@TylerHelmuth TylerHelmuth changed the title [configauth] Remove deprecated methods [configauth] Deprecate GetClientAuthenticatorContext and GetServerAuthenticatorContext Jul 9, 2024
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.33%. Comparing base (58b2496) to head (35eb7c9).

Files Patch % Lines
config/configauth/configauth.go 33.33% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10578   +/-   ##
=======================================
  Coverage   92.33%   92.33%           
=======================================
  Files         395      395           
  Lines       18673    18673           
=======================================
  Hits        17242    17242           
  Misses       1070     1070           
  Partials      361      361           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeboten codeboten merged commit 4c7d342 into open-telemetry:main Jul 9, 2024
48 of 49 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 9, 2024
@TylerHelmuth TylerHelmuth deleted the configauth-removed-deprecated-funcs branch July 9, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants