Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/debug] Add profiling support #11155

Closed
mx-psi opened this issue Sep 12, 2024 · 0 comments · Fixed by #11494
Closed

[exporter/debug] Add profiling support #11155

mx-psi opened this issue Sep 12, 2024 · 0 comments · Fixed by #11494
Labels
exporter/debug Issues related to the Debug exporter
Milestone
Profiling support

Comments

@mx-psi
Copy link
Member

mx-psi commented Sep 12, 2024

The debug exporter would be really useful for initial testing and validation of the profiling signal.

This PR adds support for the OTLP exporter and can be used as inspiration: #11131
@mx-psi mx-psi added the exporter/debug Issues related to the Debug exporter label Sep 12, 2024
@mx-psi mx-psi added this to the Profiling support milestone Sep 12, 2024
@julianocosta89 julianocosta89 mentioned this issue Sep 12, 2024
Merged
mx-psi pushed a commit that referenced this issue Oct 4, 2024
@julianocosta89
[chore]: Add Profiles Marshaler to otlptext (#11161)
13951af 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
This is the initial work towards #11155.
This PR adds profiles marshalers to `otlptext`, which will be used in
the `debugexporter` later on.

To continue the work on the `debugexporter` I'd wait on the PR #11131,
as it adds some shared components.

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Added `TestProfilesText`, testing the following scenarios: 
- `empty_profiles`
- `two_profiles`
jackgopack4 pushed a commit to jackgopack4/opentelemetry-collector that referenced this issue Oct 8, 2024
@julianocosta89 @jackgopack4
[chore]: Add Profiles Marshaler to otlptext (open-telemetry#11161)
1283000 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
This is the initial work towards open-telemetry#11155.
This PR adds profiles marshalers to `otlptext`, which will be used in
the `debugexporter` later on.

To continue the work on the `debugexporter` I'd wait on the PR open-telemetry#11131,
as it adds some shared components.

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Added `TestProfilesText`, testing the following scenarios: 
- `empty_profiles`
- `two_profiles`
@julianocosta89 julianocosta89 mentioned this issue Oct 21, 2024
Merged
djaglowski pushed a commit to djaglowski/opentelemetry-collector that referenced this issue Nov 21, 2024
@julianocosta89 @djaglowski
[debugexporter] Add support for profiles signal (open-telemetry#11494)
3f9805d 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This PR adds Profiles support to the `debugexporter` component.

<!-- Issue number if applicable -->
#### Link to tracking issue
Fixes open-telemetry#11155.

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Added tests to all modified modules:
- `exporter/debugexporter/exporter_test.go`
- `exporter/debugexporter/factory_test.go`
- `exporter/debugexporter/internal/normal/profiles_test.go`
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this issue Dec 19, 2024
@julianocosta89 @HongChenTW
[chore]: Add Profiles Marshaler to otlptext (open-telemetry#11161)
6c32a5b 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
This is the initial work towards open-telemetry#11155.
This PR adds profiles marshalers to `otlptext`, which will be used in
the `debugexporter` later on.

To continue the work on the `debugexporter` I'd wait on the PR open-telemetry#11131,
as it adds some shared components.

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Added `TestProfilesText`, testing the following scenarios: 
- `empty_profiles`
- `two_profiles`
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this issue Dec 19, 2024
@julianocosta89 @HongChenTW
[debugexporter] Add support for profiles signal (open-telemetry#11494)
c54d806 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This PR adds Profiles support to the `debugexporter` component.

<!-- Issue number if applicable -->
#### Link to tracking issue
Fixes open-telemetry#11155.

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Added tests to all modified modules:
- `exporter/debugexporter/exporter_test.go`
- `exporter/debugexporter/factory_test.go`
- `exporter/debugexporter/internal/normal/profiles_test.go`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exporter/debug Issues related to the Debug exporter
Projects
None yet
Milestone
Profiling support
Development

Successfully merging a pull request may close this issue.

[debugexporter] Add support for profiles signal julianocosta89/opentelemetry-collector
1 participant
@mx-psi