[pdata] Make wrappers primitive slices mutable

Change API for primitive slice wrappers to allow changing items as it appeared to be expensive to update that data as immutable wrappers: it requires making two copies to update a slice

CHANGELOG.md

@@ -28,6 +28,13 @@
 - Deprecate `MetricDataPointFlagsImmutable` type. (#6017)
 - Deprecate `*DataPoint.[Set]FlagsImmutable()` funcs in favor of `*DataPoint.[Set]Flags()`. (#6017)
 - Deprecate `LogRecord.FlagsStruct()` and `LogRecord.SetFlagsStruct()` in favor of `LogRecord.Flags()` and `LogRecord.SetFlags()`. (#6007)
+- Primitive slice wrapper are now mutable (#5971):
+  - `pcommon.ImmutableByteSlice` is deprecated in favor of `pcommon.ByteSlice`
+  - `pcommon.ImmutableFloat64Slice` is deprecated in favor of `pcommon.Float64Slice`
+  - `pcommon.ImmutableUInt64Slice` is deprecated in favor of `pcommon.UInt64Slice`
+  - Temporarily deprecate `pcommon.NewValueBytes` that will be replaced with `pcommon.NewValueBytesEmpty` in 0.60.0
+  - Deprecate `pcommon.Map.UpsertBytes` in favor of `pcommon.Map.UpsertEmptyBytes`
+  - Deprecate `pcommon.Value.SetBytesVal` in favor of `pcommon.Value.SetEmptyBytesVal`
 
 ### 💡 Enhancements 💡
 

internal/testdata/metric.go

@@ -197,12 +197,12 @@ func initHistogramMetric(hm pmetric.Metric) {
 	hdp1.SetSum(15)
 	hdp1.SetMin(15)
 	hdp1.SetMax(15)
-	hdp1.SetBucketCounts(pcommon.NewImmutableUInt64Slice([]uint64{0, 1}))
+	hdp1.BucketCounts().FromRaw([]uint64{0, 1})
 	exemplar := hdp1.Exemplars().AppendEmpty()
 	exemplar.SetTimestamp(metricExemplarTimestamp)
 	exemplar.SetDoubleVal(15)
 	initMetricExemplarAttributes(exemplar.FilteredAttributes())
-	hdp1.SetExplicitBounds(pcommon.NewImmutableFloat64Slice([]float64{1}))
+	hdp1.ExplicitBounds().FromRaw([]float64{1})
 }
 
 func initExponentialHistogramMetric(hm pmetric.Metric) {
@@ -220,10 +220,10 @@ func initExponentialHistogramMetric(hm pmetric.Metric) {
 
 	// positive index 1 and 2 are values sqrt(2), 2 at scale 1
 	hdp0.Positive().SetOffset(1)
-	hdp0.Positive().SetBucketCounts(pcommon.NewImmutableUInt64Slice([]uint64{1, 1}))
+	hdp0.Positive().BucketCounts().FromRaw([]uint64{1, 1})
 	// negative index -1 and 0 are values -1/sqrt(2), -1 at scale 1
 	hdp0.Negative().SetOffset(-1)
-	hdp0.Negative().SetBucketCounts(pcommon.NewImmutableUInt64Slice([]uint64{1, 1}))
+	hdp0.Negative().BucketCounts().FromRaw([]uint64{1, 1})
 
 	// The above will print:
 	// Bucket (-1.414214, -1.000000], Count: 1
@@ -245,7 +245,7 @@ func initExponentialHistogramMetric(hm pmetric.Metric) {
 
 	// index -1 and 0 are values 0.25, 1 at scale -1
 	hdp1.Positive().SetOffset(-1)
-	hdp1.Positive().SetBucketCounts(pcommon.NewImmutableUInt64Slice([]uint64{1, 1}))
+	hdp1.Positive().BucketCounts().FromRaw([]uint64{1, 1})
 
 	// The above will print:
 	// Bucket [0, 0], Count: 1

pdata/internal/cmd/pdatagen/internal/base_fields.go

@@ -62,12 +62,13 @@ const copyToPrimitiveSliceTestTemplate = `	if len(ms.getOrig().${originFieldName
 
 const accessorsPrimitiveSliceTemplate = `// ${fieldName} returns the ${lowerFieldName} associated with this ${structName}.
 func (ms ${structName}) ${fieldName}() ${packageName}${returnType} {
-	return ${packageName}${returnType}(internal.New${returnType}(ms.getOrig().${originFieldName}))
+	return ${packageName}${returnType}(internal.New${returnType}(&ms.getOrig().${originFieldName}))
 }
 
 // Set${fieldName} replaces the ${lowerFieldName} associated with this ${structName}.
+// Deprecated: [0.60.0] Use ${fieldName}().FromRaw() instead
 func (ms ${structName}) Set${fieldName}(v ${packageName}${returnType}) {
-	ms.getOrig().${originFieldName} = internal.GetOrig${returnType}(internal.${returnType}(v))
+	ms.getOrig().${originFieldName} = *internal.GetOrig${returnType}(internal.${returnType}(v))
 }`
 
 const oneOfTypeAccessorHeaderTemplate = `// ${originFieldName}Type returns the type of the ${lowerOriginFieldName} for this ${structName}.
@@ -163,10 +164,9 @@ const accessorsPrimitiveTypedTestTemplate = `func Test${structName}_${fieldName}
 
 const accessorsPrimitiveSliceTestTemplate = `func Test${structName}_${fieldName}(t *testing.T) {
 	ms := New${structName}()
-	assert.Equal(t, ${packageName}New${returnType}(${defaultVal}), ms.${fieldName}())
-	testVal${fieldName} := ${packageName}New${returnType}(${testValue})
-	ms.Set${fieldName}(testVal${fieldName})
-	assert.Equal(t, testVal${fieldName}, ms.${fieldName}())
+	assert.Equal(t, ${defaultVal}, ms.${fieldName}().AsRaw())
+	ms.${fieldName}().FromRaw(${testValue})
+	assert.Equal(t, ${testValue}, ms.${fieldName}().AsRaw())
 }`
 
 const accessorsOptionalPrimitiveValueTemplate = `// ${fieldName} returns the ${lowerFieldName} associated with this ${structName}.

pdata/internal/cmd/pdatagen/internal/metrics_structs.go

@@ -534,7 +534,7 @@ var valueFloat64Field = &primitiveField{
 var bucketCountsField = &primitiveSliceField{
 	fieldName:         "BucketCounts",
 	originFieldName:   "BucketCounts",
-	returnType:        "ImmutableUInt64Slice",
+	returnType:        "UInt64Slice",
 	returnPackageName: "pcommon",
 	defaultVal:        "[]uint64(nil)",
 	rawType:           "[]uint64",
@@ -544,7 +544,7 @@ var bucketCountsField = &primitiveSliceField{
 var explicitBoundsField = &primitiveSliceField{
 	fieldName:         "ExplicitBounds",
 	originFieldName:   "ExplicitBounds",
-	returnType:        "ImmutableFloat64Slice",
+	returnType:        "Float64Slice",
 	returnPackageName: "pcommon",
 	defaultVal:        "[]float64(nil)",
 	rawType:           "[]float64",