[receiver/kubeletstats] Refactor setting of volume labels #9745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move setting of PVC labels to the same function where labels for other volumes are set. This removes unnecessary cohesion and unblocks straight forward migration to the metrics builder v2.
TylerHelmuth
reviewed
May 5, 2022
TylerHelmuth
approved these changes
May 5, 2022
|
@open-telemetry/collector-contrib-approvers please review. |
|
@codeboten @bogdandrutu can you please take a look? |
bogdandrutu
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move setting of PVC labels to the same function where labels for other volumes are set. This increases cohesion and unblocks a straight forward migration to the metrics builder v2.
All the obsolete "label" naming should go away with migration to the metrics builder