-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exporter/datadogexporter: use pkg/trace #9693
Conversation
f312a7a
to
33e23ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a first pass on this and left a lot of comments, some of them because I don't understand the logic of the APM side as well as I would like 😅
This is a huge PR and I would prefer to the extent that it is possible to focus it exclusively only on changes that relate to swapping the current logic by pkg/trace
and leave everything else out; the other changes make sense but we can leave them for a different PR
I think it is also very important to document the changes in behavior from the current logic to the one that we are adding. I would suggest adding this as a 'breaking change' in the changelog and list down important details in the logic that will change after the swap is complete.
f288438
to
6a99a4a
Compare
a692d16
to
7b3ddbc
Compare
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
04d7e92
to
57746af
Compare
b57a506
to
7882db9
Compare
Description:
This change make use of the exact same code that the Datadog Agent uses for processing traces. A module was created in the Datadog Agent repository that is now imported here:
github.com/DataDog/datadog-agent/pkg/trace
.This change should allow for more consistent and stable behaviour.
Testing:
All unit tests were kept. Removed functionality was moved to the
pkg/trace
module as part of DataDog/datadog-agent#11548.Documentation:
Attributes are mapped to Datadog container tags internally as follows (considering the left side OTLP attributes are set in the SDKs):